Messages in this thread | | | From | Tao Ren <> | Subject | Re: [PATCH net-next 1/2] net: phy: broadcom: set features explicitly for BCM54616S | Date | Tue, 30 Jul 2019 05:05:35 +0000 |
| |
On 7/29/19 8:35 PM, Andrew Lunn wrote: > On Mon, Jul 29, 2019 at 05:25:32PM -0700, Tao Ren wrote: >> BCM54616S feature "PHY_GBIT_FEATURES" was removed by commit dcdecdcfe1fc >> ("net: phy: switch drivers to use dynamic feature detection"). As dynamic >> feature detection doesn't work when BCM54616S is working in RGMII-Fiber >> mode (different sets of MII Control/Status registers being used), let's >> set "PHY_GBIT_FEATURES" for BCM54616S explicitly. > > Hi Tao > > What exactly does it get wrong? > > Thanks > Andrew
Hi Andrew,
BCM54616S is set to RGMII-Fiber (1000Base-X) mode on my platform, and none of the features (1000BaseT/100BaseT/10BaseT) can be detected by genphy_read_abilities(), because the PHY only reports 1000BaseX_Full|Half ability in this mode.
Thanks,
Tao
| |