lkml.org 
[lkml]   [2019]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver
    Date
    Quoting Bjorn Andersson (2019-05-23 12:09:25)
    >
    > I had to read through the clock code to conclude that this was indeed
    > the design, so I'm happy with your patch of ensuring that this is
    > followed. Perhaps add a statement in the kerneldoc for struct clk_hw as
    > well to state that init won't be accessed past the return of
    > clk_register.
    >

    I noticed that I had a branch for this that didn't go away this rebase.
    I've thrown this on my todo list now.

    I added the comment to the code, but I'm afraid I can't just merge this
    patch to clk-next yet because various drivers access hw->init after
    calling clk_register() and friends. I'll have to go through and find the
    users by looking at git grep '->init' -- drivers/clk/ results. This is a
    pain.

    \
     
     \ /
      Last update: 2019-07-31 00:51    [W:3.702 / U:1.456 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site