Messages in this thread | | | Subject | Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through | From | Benjamin Herrenschmidt <> | Date | Tue, 30 Jul 2019 13:37:50 -0700 |
| |
On Tue, 2019-07-30 at 10:07 -0700, Kees Cook wrote: > > > Why do we think it's an expected fall through? I can't really > > convince > > myself from the surrounding code that it's definitely intentional. > > Yeah, good question. Just now when I went looking for who > used SMU_I2C_TRANSFER_COMBINED, I found the only caller in > arch/powerpc/platforms/powermac/low_i2c.c and it is clearly using a > fall-through for building the command for "stdsub" and "combined", > so I think that's justification enough:
Yes, sorry for the delay, the fall through is intentional.
Cheers, Ben.
| |