Messages in this thread | | | Date | Wed, 3 Jul 2019 16:01:28 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 2/2] ftrace/selftest: Test if set_event/ftrace_pid exists before writing |
| |
On Wed, 3 Jul 2019 16:00:09 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> > diff --git a/tools/testing/selftests/ftrace/test.d/functions b/tools/testing/selftests/ftrace/test.d/functions > > index 779ec11f61bd..a7b06291e32c 100644 > > --- a/tools/testing/selftests/ftrace/test.d/functions > > +++ b/tools/testing/selftests/ftrace/test.d/functions > > @@ -91,8 +91,8 @@ initialize_ftrace() { # Reset ftrace to initial-state > > reset_events_filter > > reset_ftrace_filter > > disable_events > > - echo > set_event_pid # event tracer is always on > > - echo > set_ftrace_pid > > + [ -f set_event_pid ] && echo > set_event_pid # event tracer is always on > > I probably should remove that comment, because I believe that was why > it wasn't tested :-/
Masami,
I'll wait for your review before posting a v2 without this comment.
-- Steve
| |