Messages in this thread | | | Subject | Re: [PATCH] fs/seq_file: Replace a seq_printf() call by seq_puts() in seq_hex_dump() | From | "Enrico Weigelt, metux IT consult" <> | Date | Wed, 3 Jul 2019 11:53:46 +0200 |
| |
On 02.07.19 18:38, Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 2 Jul 2019 18:28:10 +0200 > > A string which did not contain a data format specification should be put > into a sequence. Thus use the corresponding function “seq_puts”.
Looks good, but have you checked whether "m" could ever be NULL and whether seq_puts() has a check for that ?
--mtx
-- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287
| |