Messages in this thread | | | From | Saeed Mahameed <> | Subject | Re: [PATCH] net/mlx5: fix -Wtype-limits compilation warnings | Date | Mon, 29 Jul 2019 18:51:38 +0000 |
| |
On Mon, 2019-07-22 at 14:34 -0400, Qian Cai wrote: > The commit b9a7ba556207 ("net/mlx5: Use event mask based on device > capabilities") introduced a few compilation warnings due to it bumps > MLX5_EVENT_TYPE_MAX from 0x27 to 0x100 which is always greater than > an "struct {mlx5_eqe|mlx5_nb}.type" that is an "u8". > > drivers/net/ethernet/mellanox/mlx5/core/eq.c: In function > 'mlx5_eq_notifier_register': > drivers/net/ethernet/mellanox/mlx5/core/eq.c:948:21: warning: > comparison > is always false due to limited range of data type [-Wtype-limits] > if (nb->event_type >= MLX5_EVENT_TYPE_MAX) > ^~ > drivers/net/ethernet/mellanox/mlx5/core/eq.c: In function > 'mlx5_eq_notifier_unregister': > drivers/net/ethernet/mellanox/mlx5/core/eq.c:959:21: warning: > comparison > is always false due to limited range of data type [-Wtype-limits] > if (nb->event_type >= MLX5_EVENT_TYPE_MAX) > > Fix them by removing unnecessary checkings. > > Fixes: b9a7ba556207 ("net/mlx5: Use event mask based on device > capabilities") > Signed-off-by: Qian Cai <cai@lca.pw> >
Applied to mlx5-next.
Thanks, Saeed.
| |