Messages in this thread | | | Date | Mon, 29 Jul 2019 11:16:58 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH] perf pmu-events: Fix the missing "cpu_clk_unhalted.core" |
| |
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c > index 1a91a197cafb..d413761621b0 100644 > --- a/tools/perf/pmu-events/jevents.c > +++ b/tools/perf/pmu-events/jevents.c > @@ -453,6 +453,7 @@ static struct fixed { > { "inst_retired.any_p", "event=0xc0" }, > { "cpu_clk_unhalted.ref", "event=0x0,umask=0x03" }, > { "cpu_clk_unhalted.thread", "event=0x3c" }, > + { "cpu_clk_unhalted.core", "event=0x3c" },
Not sure this is correct for non Atom.
On Atom thread==core, but that is not true with SMT/HyperThreading.
The big cores currently don't have this event, so it would match incorrectly.
This has to be handled on the event list level, perhaps with some enhancements.
-Andi
| |