lkml.org 
[lkml]   [2019]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arcnet: com20020-isa: Mark expected switch fall-throughs
On Mon, Jul 29, 2019 at 09:25:03AM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/net/arcnet/com20020-isa.c: warning: this statement may fall
> through [-Wimplicit-fallthrough=]: => 205:13, 203:10, 209:7, 201:11,
> 207:8
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
> drivers/net/arcnet/com20020-isa.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/arcnet/com20020-isa.c b/drivers/net/arcnet/com20020-isa.c
> index 28510e33924f..cd27fdc1059b 100644
> --- a/drivers/net/arcnet/com20020-isa.c
> +++ b/drivers/net/arcnet/com20020-isa.c
> @@ -197,16 +197,22 @@ static int __init com20020isa_setup(char *s)
> switch (ints[0]) {
> default: /* ERROR */
> pr_info("Too many arguments\n");
> + /* Fall through */
> case 6: /* Timeout */
> timeout = ints[6];
> + /* Fall through */
> case 5: /* CKP value */
> clockp = ints[5];
> + /* Fall through */
> case 4: /* Backplane flag */
> backplane = ints[4];
> + /* Fall through */
> case 3: /* Node ID */
> node = ints[3];
> + /* Fall through */
> case 2: /* IRQ */
> irq = ints[2];
> + /* Fall through */
> case 1: /* IO address */
> io = ints[1];
> }
> --
> 2.22.0
>

--
Kees Cook

\
 
 \ /
  Last update: 2019-07-29 18:01    [W:0.049 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site