Messages in this thread | | | Date | Mon, 29 Jul 2019 16:27:44 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v3 1/2] pidfd: add P_PIDFD to waitid() |
| |
On 07/28, Christian Brauner wrote: > > +static struct pid *pidfd_get_pid(unsigned int fd) > +{ > + struct fd f; > + struct pid *pid; > + > + f = fdget(fd); > + if (!f.file) > + return ERR_PTR(-EBADF); > + > + pid = pidfd_pid(f.file); > + if (!IS_ERR(pid)) > + get_pid(pid); > + > + fdput(f); > + return pid; > +}
Agreed, this looks better than the previous version.
FWIW,
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
| |