Messages in this thread | | | From | Masahiro Yamada <> | Date | Mon, 29 Jul 2019 22:45:01 +0900 | Subject | Re: [PATCH 1/5] pinctrl: uniphier: Separate modem group from UART ctsrts group |
| |
On Tue, Jul 9, 2019 at 7:29 PM Kunihiko Hayashi <hayashi.kunihiko@socionext.com> wrote: > > It depends on the board implementation whether to have each pins of > CTS/RTS, and others for modem. So it is necessary to divide current > uart_ctsrts group into uart_ctsrts and uart_modem groups. > > Since the number of implemented pins for modem differs depending > on SoC, each uart_modem group also has a different number of pins. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > ---
> diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-ld6b.c b/drivers/pinctrl/uniphier/pinctrl-uniphier-ld6b.c > index 414ff3a..d1ed5b7 100644 > --- a/drivers/pinctrl/uniphier/pinctrl-uniphier-ld6b.c > +++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-ld6b.c > @@ -780,8 +780,10 @@ static const unsigned system_bus_cs5_pins[] = {55}; > static const int system_bus_cs5_muxvals[] = {6}; > static const unsigned uart0_pins[] = {135, 136}; > static const int uart0_muxvals[] = {3, 3}; > -static const unsigned uart0_ctsrts_pins[] = {137, 138, 139, 140, 141, 124}; > -static const int uart0_ctsrts_muxvals[] = {3, 3, 3, 3, 3, 3}; > +static const unsigned uart0_ctsrts_pins[] = {137, 139}; > +static const int uart0_ctsrts_muxvals[] = {3, 3}; > +static const unsigned uart0_modem_pins[] = {138, 140, 141, 124};
Please sort this array while you are here.
Otherwise, looks good to me.
-- Best Regards Masahiro Yamada
| |