Messages in this thread | | | From | Nick Desaulniers <> | Date | Mon, 29 Jul 2019 13:45:35 -0700 | Subject | Re: [PATCH] powerpc: workaround clang codegen bug in dcbz |
| |
On Mon, Jul 29, 2019 at 1:32 PM Nathan Chancellor <natechancellor@gmail.com> wrote: > > On Mon, Jul 29, 2019 at 01:25:41PM -0700, Nick Desaulniers wrote: > > But I'm not sure how the inlined code generated would be affected. > > For the record: > > https://godbolt.org/z/z57VU7 > > This seems consistent with what Michael found so I don't think a revert > is entirely unreasonable.
Thanks for debugging/reporting/testing and the Godbolt link which clearly shows that the codegen for out of line versions is no different. The case I can't comment on is what happens when those `static inline` functions get inlined (maybe the original patch improves those cases?). -- Thanks, ~Nick Desaulniers
| |