lkml.org 
[lkml]   [2019]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 253/293] mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk
    Date
    [ Upstream commit 7efd105c27fd2323789b41b64763a0e33ed79c08 ]

    Since devm_regmap_init_mmio_clk can fail, add return value checking.

    Signed-off-by: Axel Lin <axel.lin@ingics.com>
    Acked-by: Chen Feng <puck.chen@hisilicon.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mfd/hi655x-pmic.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
    index 96c07fa1802a..6693f74aa6ab 100644
    --- a/drivers/mfd/hi655x-pmic.c
    +++ b/drivers/mfd/hi655x-pmic.c
    @@ -112,6 +112,8 @@ static int hi655x_pmic_probe(struct platform_device *pdev)

    pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base,
    &hi655x_regmap_config);
    + if (IS_ERR(pmic->regmap))
    + return PTR_ERR(pmic->regmap);

    regmap_read(pmic->regmap, HI655X_BUS_ADDR(HI655X_VER_REG), &pmic->ver);
    if ((pmic->ver < PMU_VER_START) || (pmic->ver > PMU_VER_END)) {
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-07-29 22:10    [W:4.053 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site