lkml.org 
[lkml]   [2019]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 077/113] f2fs: avoid out-of-range memory access
    Date
    [ Upstream commit 56f3ce675103e3fb9e631cfb4131fc768bc23e9a ]

    blkoff_off might over 512 due to fs corrupt or security
    vulnerability. That should be checked before being using.

    Use ENTRIES_IN_SUM to protect invalid value in cur_data_blkoff.

    Signed-off-by: Ocean Chen <oceanchen@google.com>
    Reviewed-by: Chao Yu <yuchao0@huawei.com>
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/f2fs/segment.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
    index 8fc3edb6760c..92f72bb5aff4 100644
    --- a/fs/f2fs/segment.c
    +++ b/fs/f2fs/segment.c
    @@ -3261,6 +3261,11 @@ static int read_compacted_summaries(struct f2fs_sb_info *sbi)
    seg_i = CURSEG_I(sbi, i);
    segno = le32_to_cpu(ckpt->cur_data_segno[i]);
    blk_off = le16_to_cpu(ckpt->cur_data_blkoff[i]);
    + if (blk_off > ENTRIES_IN_SUM) {
    + f2fs_bug_on(sbi, 1);
    + f2fs_put_page(page, 1);
    + return -EFAULT;
    + }
    seg_i->next_segno = segno;
    reset_curseg(sbi, i, 0);
    seg_i->alloc_type = ckpt->alloc_type[i];
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-07-29 22:10    [W:4.912 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site