lkml.org 
[lkml]   [2019]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 089/215] dt-bindings: backlight: lm3630a: correct schema validation
    Date
    [ Upstream commit ef4db28c1f45cda6989bc8a8e45294894786d947 ]

    The '#address-cells' and '#size-cells' properties were not defined in
    the lm3630a bindings and would cause the following error when
    attempting to validate the examples against the schema:

    Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml:
    '#address-cells', '#size-cells' do not match any of the regexes:
    '^led@[01]$', 'pinctrl-[0-9]+'

    Correct this by adding those two properties.

    While we're here, move the ti,linear-mapping-mode property to the
    led@[01] child nodes to correct the following validation error:

    Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml:
    led@0: 'ti,linear-mapping-mode' does not match any of the regexes:
    'pinctrl-[0-9]+'

    Fixes: 32fcb75c66a0 ("dt-bindings: backlight: Add lm3630a bindings")
    Signed-off-by: Brian Masney <masneyb@onstation.org>
    Reported-by: Rob Herring <robh+dt@kernel.org>
    Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
    Acked-by: Dan Murphy <dmurphy@ti.com>
    [robh: also drop maxItems from child reg]
    Signed-off-by: Rob Herring <robh@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    .../leds/backlight/lm3630a-backlight.yaml | 21 ++++++++++++-------
    1 file changed, 14 insertions(+), 7 deletions(-)

    diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
    index 4d61fe0a98a4..dc129d9a329e 100644
    --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
    +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
    @@ -23,16 +23,17 @@ properties:
    reg:
    maxItems: 1

    - ti,linear-mapping-mode:
    - description: |
    - Enable linear mapping mode. If disabled, then it will use exponential
    - mapping mode in which the ramp up/down appears to have a more uniform
    - transition to the human eye.
    - type: boolean
    + '#address-cells':
    + const: 1
    +
    + '#size-cells':
    + const: 0

    required:
    - compatible
    - reg
    + - '#address-cells'
    + - '#size-cells'

    patternProperties:
    "^led@[01]$":
    @@ -48,7 +49,6 @@ patternProperties:
    in this property. The two current sinks can be controlled
    independently with both banks, or bank A can be configured to control
    both sinks with the led-sources property.
    - maxItems: 1
    minimum: 0
    maximum: 1

    @@ -73,6 +73,13 @@ patternProperties:
    minimum: 0
    maximum: 255

    + ti,linear-mapping-mode:
    + description: |
    + Enable linear mapping mode. If disabled, then it will use exponential
    + mapping mode in which the ramp up/down appears to have a more uniform
    + transition to the human eye.
    + type: boolean
    +
    required:
    - reg

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-07-29 22:09    [W:2.258 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site