Messages in this thread | | | Date | Sat, 27 Jul 2019 19:15:54 +0200 | From | Jiri Olsa <> | Subject | Re: [patch] perf.data documentation has wrong units for memory size |
| |
On Thu, Jul 25, 2019 at 11:57:43AM -0400, Vince Weaver wrote: > > The perf.data-file-format documentation incorrectly says the > HEADER_TOTAL_MEM results are in bytes. The results are in kilobytes > (perf reads the value from /proc/meminfo) > > Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks, jirka
> > diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt > index 5f54feb19977..d030c87ed9f5 100644 > --- a/tools/perf/Documentation/perf.data-file-format.txt > +++ b/tools/perf/Documentation/perf.data-file-format.txt > @@ -126,7 +126,7 @@ vendor,family,model,stepping. For example: GenuineIntel,6,69,1 > > HEADER_TOTAL_MEM = 10, > > -An uint64_t with the total memory in bytes. > +An uint64_t with the total memory in kilobytes. > > HEADER_CMDLINE = 11, >
| |