lkml.org 
[lkml]   [2019]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 28/47] x86/apic: Silence -Wtype-limits compiler warnings
    Date
    From: Qian Cai <cai@lca.pw>

    [ Upstream commit ec6335586953b0df32f83ef696002063090c7aef ]

    There are many compiler warnings like this,

    In file included from ./arch/x86/include/asm/smp.h:13,
    from ./arch/x86/include/asm/mmzone_64.h:11,
    from ./arch/x86/include/asm/mmzone.h:5,
    from ./include/linux/mmzone.h:969,
    from ./include/linux/gfp.h:6,
    from ./include/linux/mm.h:10,
    from arch/x86/kernel/apic/io_apic.c:34:
    arch/x86/kernel/apic/io_apic.c: In function 'check_timer':
    ./arch/x86/include/asm/apic.h:37:11: warning: comparison of unsigned
    expression >= 0 is always true [-Wtype-limits]
    if ((v) <= apic_verbosity) \
    ^~
    arch/x86/kernel/apic/io_apic.c:2160:2: note: in expansion of macro
    'apic_printk'
    apic_printk(APIC_QUIET, KERN_INFO "..TIMER: vector=0x%02X "
    ^~~~~~~~~~~
    ./arch/x86/include/asm/apic.h:37:11: warning: comparison of unsigned
    expression >= 0 is always true [-Wtype-limits]
    if ((v) <= apic_verbosity) \
    ^~
    arch/x86/kernel/apic/io_apic.c:2207:4: note: in expansion of macro
    'apic_printk'
    apic_printk(APIC_QUIET, KERN_ERR "..MP-BIOS bug: "
    ^~~~~~~~~~~

    APIC_QUIET is 0, so silence them by making apic_verbosity type int.

    Signed-off-by: Qian Cai <cai@lca.pw>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Link: https://lkml.kernel.org/r/1562621805-24789-1-git-send-email-cai@lca.pw
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/x86/include/asm/apic.h | 2 +-
    arch/x86/kernel/apic/apic.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
    index 130e81e10fc7..050368db9d35 100644
    --- a/arch/x86/include/asm/apic.h
    +++ b/arch/x86/include/asm/apic.h
    @@ -48,7 +48,7 @@ static inline void generic_apic_probe(void)

    #ifdef CONFIG_X86_LOCAL_APIC

    -extern unsigned int apic_verbosity;
    +extern int apic_verbosity;
    extern int local_apic_timer_c2_ok;

    extern int disable_apic;
    diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
    index 02020f2e0080..272a12865b2a 100644
    --- a/arch/x86/kernel/apic/apic.c
    +++ b/arch/x86/kernel/apic/apic.c
    @@ -181,7 +181,7 @@ EXPORT_SYMBOL_GPL(local_apic_timer_c2_ok);
    /*
    * Debug level, exported for io_apic.c
    */
    -unsigned int apic_verbosity;
    +int apic_verbosity;

    int pic_mode;

    --
    2.20.1
    \
     
     \ /
      Last update: 2019-07-26 15:56    [W:4.031 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site