lkml.org 
[lkml]   [2019]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 1/6] dt-bindings: opp: Introduce opp-peak-KBps and opp-avg-KBps bindings
    From
    Date
    Hi Saravana,

    On 7/3/19 04:10, Saravana Kannan wrote:
    > Interconnects often quantify their performance points in terms of
    > bandwidth. So, add opp-peak-KBps (required) and opp-avg-KBps (optional) to
    > allow specifying Bandwidth OPP tables in DT.
    >
    > opp-peak-KBps is a required property that replace opp-hz for Bandwidth OPP
    > tables.
    >
    > opp-avg-KBps is an optional property that can be used in Bandwidth OPP
    > tables.
    >
    > Signed-off-by: Saravana Kannan <saravanak@google.com>
    > ---
    > Documentation/devicetree/bindings/opp/opp.txt | 15 ++++++++++++---
    > 1 file changed, 12 insertions(+), 3 deletions(-)
    >
    > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
    > index 76b6c79604a5..c869e87caa2a 100644
    > --- a/Documentation/devicetree/bindings/opp/opp.txt
    > +++ b/Documentation/devicetree/bindings/opp/opp.txt
    > @@ -83,9 +83,14 @@ properties.
    >
    > Required properties:
    > - opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. This is a
    > - required property for all device nodes but devices like power domains. The
    > - power domain nodes must have another (implementation dependent) property which
    > - uniquely identifies the OPP nodes.
    > + required property for all device nodes but for devices like power domains or
    > + bandwidth opp tables. The power domain nodes must have another (implementation
    > + dependent) property which uniquely identifies the OPP nodes. The interconnect
    > + opps are required to have the opp-peak-bw property.
    > +
    > +- opp-peak-KBps: Peak bandwidth in kilobytes per second, expressed as a 32-bit

    As Rob already mentioned, KBps should be documented. See [1].

    Thanks,
    Georgi

    [1] https://lore.kernel.org/lkml/20190423132823.7915-2-georgi.djakov@linaro.org/

    \
     
     \ /
      Last update: 2019-07-26 18:25    [W:4.212 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site