| Date | Thu, 25 Jul 2019 07:20:29 -0700 | From | tip-bot for Thomas Gleixner <> | Subject | [tip:x86/apic] x86/kgbd: Use NMI_VECTOR not APIC_DM_NMI |
| |
Commit-ID: 2591bc4e8d70b4e1330d327fb7e3921f4e070a51 Gitweb: https://git.kernel.org/tip/2591bc4e8d70b4e1330d327fb7e3921f4e070a51 Author: Thomas Gleixner <tglx@linutronix.de> AuthorDate: Mon, 22 Jul 2019 20:47:06 +0200 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Thu, 25 Jul 2019 16:11:56 +0200
x86/kgbd: Use NMI_VECTOR not APIC_DM_NMI
apic->send_IPI_allbutself() takes a vector number as argument.
APIC_DM_NMI is clearly not a vector number. It's defined to 0x400 which is outside the vector space.
Use NMI_VECTOR instead as that's what it is intended to be.
Fixes: 82da3ff89dc2 ("x86: kgdb support") Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20190722105218.855189979@linutronix.de
--- arch/x86/kernel/kgdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c index 23297ea64f5f..a53dfb09880f 100644 --- a/arch/x86/kernel/kgdb.c +++ b/arch/x86/kernel/kgdb.c @@ -416,7 +416,7 @@ static void kgdb_disable_hw_debug(struct pt_regs *regs) */ void kgdb_roundup_cpus(void) { - apic->send_IPI_allbutself(APIC_DM_NMI); + apic->send_IPI_allbutself(NMI_VECTOR); } #endif
|