lkml.org 
[lkml]   [2019]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 11/12] staging: media: cedrus: Fix misuse of GENMASK macro
    From
    Date
    On 7/24/19 7:09 PM, Joe Perches wrote:
    > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote:
    >> Arguments are supposed to be ordered high then low.
    >>
    >> Signed-off-by: Joe Perches <joe@perches.com>
    >> ---
    >> drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 2 +-
    >> 1 file changed, 1 insertion(+), 1 deletion(-)
    >>
    >> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_regs.h b/drivers/staging/media/sunxi/cedrus/cedrus_regs.h
    >> index 3e9931416e45..ddd29788d685 100644
    >> --- a/drivers/staging/media/sunxi/cedrus/cedrus_regs.h
    >> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_regs.h
    >> @@ -110,7 +110,7 @@
    >> #define VE_DEC_MPEG_MBADDR (VE_ENGINE_DEC_MPEG + 0x10)
    >>
    >> #define VE_DEC_MPEG_MBADDR_X(w) (((w) << 8) & GENMASK(15, 8))
    >> -#define VE_DEC_MPEG_MBADDR_Y(h) (((h) << 0) & GENMASK(0, 7))
    >> +#define VE_DEC_MPEG_MBADDR_Y(h) (((h) << 0) & GENMASK(7, 0))
    >>
    >> #define VE_DEC_MPEG_CTRL (VE_ENGINE_DEC_MPEG + 0x14)
    >
    > Greg? ping?
    >
    >

    It's actually me and I'm about to pick this one up and make a PR for Mauro.

    Regards,

    Hans

    \
     
     \ /
      Last update: 2019-07-25 08:47    [W:4.293 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site