lkml.org 
[lkml]   [2019]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 262/271] mtd: spinand: read returns badly if the last page has bitflips
    Date
    From: liaoweixiong <liaoweixiong@allwinnertech.com>

    commit b83408b580eccf8d2797cd6cb9ae42c2a28656a7 upstream.

    In case of the last page containing bitflips (ret > 0),
    spinand_mtd_read() will return that number of bitflips for the last
    page while it should instead return max_bitflips like it does when the
    last page read returns with 0.

    Signed-off-by: Weixiong Liao <liaoweixiong@allwinnertech.com>
    Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
    Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
    Cc: stable@vger.kernel.org
    Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mtd/nand/spi/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mtd/nand/spi/core.c
    +++ b/drivers/mtd/nand/spi/core.c
    @@ -572,12 +572,12 @@ static int spinand_mtd_read(struct mtd_i
    if (ret == -EBADMSG) {
    ecc_failed = true;
    mtd->ecc_stats.failed++;
    - ret = 0;
    } else {
    mtd->ecc_stats.corrected += ret;
    max_bitflips = max_t(unsigned int, max_bitflips, ret);
    }

    + ret = 0;
    ops->retlen += iter.req.datalen;
    ops->oobretlen += iter.req.ooblen;
    }

    \
     
     \ /
      Last update: 2019-07-25 07:47    [W:4.071 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site