lkml.org 
[lkml]   [2019]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro
    From
    Date
    On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote:
    > Arguments are supposed to be ordered high then low.
    >
    > Signed-off-by: Joe Perches <joe@perches.com>
    > ---
    > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/drivers/gpu/drm/aspeed/aspeed_gfx.h
    > index a10358bb61ec..095ea03e5833 100644
    > --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h
    > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h
    > @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm);
    > /* CTRL2 */
    > #define CRT_CTRL_DAC_EN BIT(0)
    > #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & CRT_CTRL_VBLANK_LINE_MASK)
    > -#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(20, 31)
    > +#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(31, 20)

    ping?


    \
     
     \ /
      Last update: 2019-07-24 19:17    [W:4.060 / U:0.648 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site