| Date | Tue, 23 Jul 2019 22:30:53 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 03/12] block: bio_release_pages: use flags arg instead of bool |
| |
On Tue, Jul 23, 2019 at 09:25:09PM -0700, john.hubbard@gmail.com wrote: > From: John Hubbard <jhubbard@nvidia.com> > > In commit d241a95f3514 ("block: optionally mark pages dirty in > bio_release_pages"), new "bool mark_dirty" argument was added to > bio_release_pages. > > In upcoming work, another bool argument (to indicate that the pages came > from get_user_pages) is going to be added. That's one bool too many, > because it's not desirable have calls of the form:
All pages releases by bio_release_pages should come from get_get_user_pages, so I don't really see the point here.
|