lkml.org 
[lkml]   [2019]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 014/271] batman-adv: fix for leaked TVLV handler.
    Date
    [ Upstream commit 17f78dd1bd624a4dd78ed5db3284a63ee807fcc3 ]

    A handler for BATADV_TVLV_ROAM was being registered when the
    translation-table was initialized, but not unregistered when the
    translation-table was freed. Unregister it.

    Fixes: 122edaa05940 ("batman-adv: tvlv - convert roaming adv packet to use tvlv unicast packets")
    Reported-by: syzbot+d454a826e670502484b8@syzkaller.appspotmail.com
    Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
    Signed-off-by: Sven Eckelmann <sven@narfation.org>
    Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/batman-adv/translation-table.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
    index 359ec1a6e822..9fa5389ea244 100644
    --- a/net/batman-adv/translation-table.c
    +++ b/net/batman-adv/translation-table.c
    @@ -3821,6 +3821,8 @@ static void batadv_tt_purge(struct work_struct *work)
    */
    void batadv_tt_free(struct batadv_priv *bat_priv)
    {
    + batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_ROAM, 1);
    +
    batadv_tvlv_container_unregister(bat_priv, BATADV_TVLV_TT, 1);
    batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_TT, 1);

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-07-24 22:09    [W:4.030 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site