lkml.org 
[lkml]   [2019]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 092/271] ipsec: select crypto ciphers for xfrm_algo
    Date
    [ Upstream commit 597179b0ba550bd83fab1a9d57c42a9343c58514 ]

    kernelci.org reports failed builds on arc because of what looks
    like an old missed 'select' statement:

    net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs':
    xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash'

    I don't see this in randconfig builds on other architectures, but
    it's fairly clear we want to select the hash code for it, like we
    do for all its other users. As Herbert points out, CRYPTO_BLKCIPHER
    is also required even though it has not popped up in build tests.

    Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/xfrm/Kconfig | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
    index 4a9ee2d83158..372c91faa283 100644
    --- a/net/xfrm/Kconfig
    +++ b/net/xfrm/Kconfig
    @@ -14,6 +14,8 @@ config XFRM_ALGO
    tristate
    select XFRM
    select CRYPTO
    + select CRYPTO_HASH
    + select CRYPTO_BLKCIPHER

    config XFRM_USER
    tristate "Transformation user configuration interface"
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-07-24 22:07    [W:3.738 / U:2.576 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site