lkml.org 
[lkml]   [2019]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.1 006/371] ath10k: Check tx_stats before use it
    Date
    [ Upstream commit 9e7251fa38978b85108c44743e1436d48e8d0d76 ]

    tx_stats will be freed and set to NULL before debugfs_sta node is
    removed in station disconnetion process. So if read the debugfs_sta
    node there may be NULL pointer error. Add check for tx_stats before
    use it to resove this issue.

    Signed-off-by: Yingying Tang <yintang@codeaurora.org>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/ath/ath10k/debugfs_sta.c | 7 +++++++
    1 file changed, 7 insertions(+)

    diff --git a/drivers/net/wireless/ath/ath10k/debugfs_sta.c b/drivers/net/wireless/ath/ath10k/debugfs_sta.c
    index c704ae371c4d..42931a669b02 100644
    --- a/drivers/net/wireless/ath/ath10k/debugfs_sta.c
    +++ b/drivers/net/wireless/ath/ath10k/debugfs_sta.c
    @@ -663,6 +663,13 @@ static ssize_t ath10k_dbg_sta_dump_tx_stats(struct file *file,

    mutex_lock(&ar->conf_mutex);

    + if (!arsta->tx_stats) {
    + ath10k_warn(ar, "failed to get tx stats");
    + mutex_unlock(&ar->conf_mutex);
    + kfree(buf);
    + return 0;
    + }
    +
    spin_lock_bh(&ar->data_lock);
    for (k = 0; k < ATH10K_STATS_TYPE_MAX; k++) {
    for (j = 0; j < ATH10K_COUNTER_TYPE_MAX; j++) {
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-07-24 21:45    [W:4.051 / U:1.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site