lkml.org 
[lkml]   [2019]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 307/413] pnfs: Fix a problem where we gratuitously start doing I/O through the MDS
    Date
    From: Trond Myklebust <trond.myklebust@hammerspace.com>

    commit 58bbeab425c6c5e318f5b6ae31d351331ddfb34b upstream.

    If the client has to stop in pnfs_update_layout() to wait for another
    layoutget to complete, it currently exits and defaults to I/O through
    the MDS if the layoutget was successful.

    Fixes: d03360aaf5cc ("pNFS: Ensure we return the error if someone kills...")
    Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
    Cc: stable@vger.kernel.org # v4.20+
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/nfs/pnfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/nfs/pnfs.c
    +++ b/fs/nfs/pnfs.c
    @@ -1890,7 +1890,7 @@ lookup_again:
    spin_unlock(&ino->i_lock);
    lseg = ERR_PTR(wait_var_event_killable(&lo->plh_outstanding,
    !atomic_read(&lo->plh_outstanding)));
    - if (IS_ERR(lseg) || !list_empty(&lo->plh_segs))
    + if (IS_ERR(lseg))
    goto out_put_layout_hdr;
    pnfs_put_layout_hdr(lo);
    goto lookup_again;

    \
     
     \ /
      Last update: 2019-07-24 21:37    [W:4.087 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site