lkml.org 
[lkml]   [2019]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] leds: is31fl319x: simplify getting the adapter of a client
From
Date
Hi Wolfram,

Thank you for the patch.

On 7/22/19 8:14 PM, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/leds/leds-is31fl319x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-is31fl319x.c b/drivers/leds/leds-is31fl319x.c
> index 2d077b8edd0e..ca6634b8683c 100644
> --- a/drivers/leds/leds-is31fl319x.c
> +++ b/drivers/leds/leds-is31fl319x.c
> @@ -333,12 +333,11 @@ static int is31fl319x_probe(struct i2c_client *client,
> {
> struct is31fl319x_chip *is31;
> struct device *dev = &client->dev;
> - struct i2c_adapter *adapter = to_i2c_adapter(dev->parent);
> int err;
> int i = 0;
> u32 aggregated_led_microamp = IS31FL319X_CURRENT_MAX;
>
> - if (!i2c_check_functionality(adapter, I2C_FUNC_I2C))
> + if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
> return -EIO;
>
> is31 = devm_kzalloc(&client->dev, sizeof(*is31), GFP_KERNEL);
>

Applied.

--
Best regards,
Jacek Anaszewski

\
 
 \ /
  Last update: 2019-07-23 21:04    [W:0.056 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site