lkml.org 
[lkml]   [2019]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] lightnvm: introduce pr_fmt for the previx nvm
From
Date
> On 22 Jul 2019, at 06.31, Minwoo Im <minwoo.im@samsung.com> wrote:
>
>>> @@ -1111,27 +1112,27 @@ static int nvm_init(struct nvm_dev *dev)
>>> int ret = -EINVAL;
>>>
>>> if (dev->ops->identity(dev)) {
>>> - pr_err("nvm: device could not be identified\n");
>>> + pr_err("device could not be identified\n");
>>> goto err;
>>> }
>>>
>>> - pr_debug("nvm: ver:%u.%u nvm_vendor:%x\n",
>>> + pr_debug("ver:%u.%u nvm_vendor:%x\n",
>>> geo->major_ver_id, geo->minor_ver_id,
>>> geo->vmnt);
>> The above last 2 lines can be squashed and pr_debug call can be made in
>> 2 lines since you have removed the "nvm:" which shortens the first line.
>
> Yeah Okay. Will prepare V2 with this and also s/previx/prefix in the
> title.
>
> Thanks for the review.
>
> Minwoo Im

Besides Chaitanya’s comments, looks good. You can add my review on V2.

Reviewed-by: Javier González <javier@javigon.com>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-07-23 07:48    [W:0.056 / U:2.664 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site