lkml.org 
[lkml]   [2019]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] drm/tegra: sor: Enable HDA interrupts at plugin
From
Date
Thanks for your comments, Dmitry. Please see my responses inline.

On 7/23/2019 6:00 AM, Dmitry Osipenko wrote:
> 22.07.2019 12:27, Viswanath L пишет:
>> HDMI plugout calls runtime suspend, which clears interrupt registers
>> and causes audio functionality to break on subsequent plugin; setting
>> interrupt registers in sor_audio_prepare() solves the issue
> Hello Viswanath,
>
> A dot should be in the end of sentence, please. And should be better to
> s/plugin/plug-in/ in the commit's message/title because 'plugin' sounds
> as a noun.
[VL] Yes, I'll make the above changes.
>
> Please don't version patch as v2 if v1 wasn't ever sent out.
[VL] Now that I have sent v2, shall I continue with v2 for the next
patch? Apologies for this oversight.
>
> You should add a stable tag here to get patch backported into stable
> kernel versions:
>
> Cc: <stable@vger.kernel.org>
[VL] Yes, will add.
>
>> Signed-off-by: Viswanath L <viswanathl@nvidia.com>
> The kernel upstreaming rules require a full name. I'm pretty sure that L
> isn't yours surname.
[VL] My name appears as "Viswanath L" in all company records and email
lists. I would strongly prefer to keep it this way, unless that is an
absolute no-no.
>> ---
>> drivers/gpu/drm/tegra/sor.c | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
>> index 5be5a08..0470cfe 100644
>> --- a/drivers/gpu/drm/tegra/sor.c
>> +++ b/drivers/gpu/drm/tegra/sor.c
>> @@ -2164,6 +2164,15 @@ static void tegra_sor_audio_prepare(struct tegra_sor *sor)
>>
>> value = SOR_AUDIO_HDA_PRESENSE_ELDV | SOR_AUDIO_HDA_PRESENSE_PD;
>> tegra_sor_writel(sor, value, SOR_AUDIO_HDA_PRESENSE);
>> +
>> + /*
>> + * Enable and unmask the HDA codec SCRATCH0 register interrupt. This
>> + * is used for interoperability between the HDA codec driver and the
>> + * HDMI/DP driver.
>> + */
>> + value = SOR_INT_CODEC_SCRATCH1 | SOR_INT_CODEC_SCRATCH0;
>> + tegra_sor_writel(sor, value, SOR_INT_ENABLE);
>> + tegra_sor_writel(sor, value, SOR_INT_MASK);
>> }
>>
>> static void tegra_sor_audio_unprepare(struct tegra_sor *sor)
>> @@ -2913,15 +2922,6 @@ static int tegra_sor_init(struct host1x_client *client)
>> if (err < 0)
>> return err;
>>
>> - /*
>> - * Enable and unmask the HDA codec SCRATCH0 register interrupt. This
>> - * is used for interoperability between the HDA codec driver and the
>> - * HDMI/DP driver.
>> - */
>> - value = SOR_INT_CODEC_SCRATCH1 | SOR_INT_CODEC_SCRATCH0;
>> - tegra_sor_writel(sor, value, SOR_INT_ENABLE);
>> - tegra_sor_writel(sor, value, SOR_INT_MASK);
>> -
>> return 0;
>> }
>>
>>

\
 
 \ /
  Last update: 2019-07-23 12:11    [W:0.072 / U:46.008 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site