[lkml]   [2019]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH 0/4] video: of: display_timing: Adjust err printing of of_get_display_timing()
As reported by Sam Ravnborg [1], after commit b8a2948fa2b3
("drm/panel: simple: Add ability to override typical timing") we now
see a pointless error message printed on every boot for many systems.
Let's fix that by adjusting who is responsible for printing error
messages when of_get_display_timing() is used.

Most certainly we can bikeshed the topic about whether this is the
right fix or we should instead add logic to panel_simple_probe() to
avoid calling of_get_display_timing() in the case where there is no
"panel-timing" sub-node. If there is consensus that I should move the
fix to panel_simple_probe() I'm happy to spin this series. In that
case we probably should _remove_ the extra prints that were already
present in the other two callers of of_get_display_timing().

While at it, fix a missing of_node_put() found by code inspection.

NOTE: amba-clcd and panel-lvds were only compile-tested.


Douglas Anderson (4):
video: of: display_timing: Add of_node_put() in
video: of: display_timing: Don't yell if no timing node is present
drm: panel-lvds: Spout an error if of_get_display_timing() gives an
video: amba-clcd: Spout an error if of_get_display_timing() gives an

drivers/gpu/drm/panel/panel-lvds.c | 5 ++++-
drivers/video/fbdev/amba-clcd.c | 4 +++-
drivers/video/of_display_timing.c | 11 +++++++----
3 files changed, 14 insertions(+), 6 deletions(-)


 \ /
  Last update: 2019-07-22 20:25    [W:0.090 / U:1.756 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site