lkml.org 
[lkml]   [2019]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 7/7] backlight: gpio: use a helper variable for &pdev->dev
On Mon, Jul 22, 2019 at 05:03:02PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Instead of dereferencing pdev each time, use a helper variable for
> the associated device pointer.

> static int gpio_backlight_probe(struct platform_device *pdev)
> {
> - struct gpio_backlight_platform_data *pdata =
> - dev_get_platdata(&pdev->dev);
> + struct gpio_backlight_platform_data *pdata;
> struct backlight_properties props;
> struct backlight_device *bl;
> struct gpio_backlight *gbl;
> enum gpiod_flags flags;
> + struct device *dev;

Can't we do

struct device dev = &pdev->dev;
struct gpio_backlight_platform_data *pdata = dev_get_platdata(dev);

? It fits 80 nicely.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2019-07-22 18:10    [W:0.148 / U:8.876 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site