Messages in this thread | | | Date | Mon, 22 Jul 2019 19:51:49 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 1/3] [v2] dmaengine: dw-edma: fix unnecessary stack usage |
| |
On 22-07-19, 14:44, Arnd Bergmann wrote: > Putting large constant data on the stack causes unnecessary overhead > and stack usage: > > drivers/dma/dw-edma/dw-edma-v0-debugfs.c:285:6: error: stack frame size of 1376 bytes in function 'dw_edma_v0_debugfs_on' [-Werror,-Wframe-larger-than=] > > Mark the variable 'static const' in order for the compiler to move it > into the .rodata section where it does no such harm.
Applied all, thanks
Please do note the link was pointing to older rev, I have updated them to this revision.
-- ~Vinod
| |