Messages in this thread | | | Subject | Re: [PATCH] mfd: cros_ec: Update cros_ec_commands.h | From | Enric Balletbo i Serra <> | Date | Mon, 22 Jul 2019 16:15:49 +0200 |
| |
Hi Lee,
On 11/7/19 19:17, Gwendal Grignou wrote: > Reviewed-by: Gwendal Grignou <gwendal@chromium.org> > > Note there is a patch series that move cros_ec_commands.h from > nclude/linux/mfd/ to include/linux/platform_data. >
I just sent a new version of the patches mentioned above now that rc1 is out [1]
As Gwendal said this patch will conflict with them, so we have two options.
1. If Lee picks that patch I can rebase again my series on top of it. 2. If not, we can wait for Lee reviewing my patch series and then I don't mind to rebase that patch on top of my series and carry the patch through chrome-platform. Anyway I'll need an immutable branch from Lee.
> On Mon, Jul 8, 2019 at 11:16 AM Yicheng Li <yichengli@chromium.org> wrote: >> >> Update cros_ec_commands.h to match the fingerprint MCU section in >> the current ec_commands.h >> >> Signed-off-by: Yicheng Li <yichengli@chromium.org>
For the first case: Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Thanks, ~ Enric
[1] https://lkml.org/lkml/2019/7/22/497
>> --- >> >> include/linux/mfd/cros_ec_commands.h | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h >> index 7ccb8757b79d..98415686cbfa 100644 >> --- a/include/linux/mfd/cros_ec_commands.h >> +++ b/include/linux/mfd/cros_ec_commands.h >> @@ -5513,6 +5513,18 @@ struct ec_params_fp_seed { >> uint8_t seed[FP_CONTEXT_TPM_BYTES]; >> } __ec_align4; >> >> +#define EC_CMD_FP_ENC_STATUS 0x0409 >> + >> +/* FP TPM seed has been set or not */ >> +#define FP_ENC_STATUS_SEED_SET BIT(0) >> + >> +struct ec_response_fp_encryption_status { >> + /* Used bits in encryption engine status */ >> + uint32_t valid_flags; >> + /* Encryption engine status */ >> + uint32_t status; >> +} __ec_align4; >> + >> /*****************************************************************************/ >> /* Touchpad MCU commands: range 0x0500-0x05FF */ >> >> -- >> 2.20.1 >>
| |