lkml.org 
[lkml]   [2019]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/3] ACPI: Remove acpi_has_method() call from acpi_adxl.c
On Mon, Jul 22, 2019 at 4:36 AM Kelsey Skunberg
<skunberg.kelsey@gmail.com> wrote:
>
> acpi_check_dsm() will already return an error if the DSM method does not
> exist. Checking if the DSM method exists before the acpi_check_dsm() call
> is not needed. Remove acpi_has_method() call to avoid additional work.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
> ---
> drivers/acpi/acpi_adxl.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/acpi/acpi_adxl.c b/drivers/acpi/acpi_adxl.c
> index 13c8f7b50c46..89aac15663fd 100644
> --- a/drivers/acpi/acpi_adxl.c
> +++ b/drivers/acpi/acpi_adxl.c
> @@ -148,11 +148,6 @@ static int __init adxl_init(void)
> return -ENODEV;
> }
>
> - if (!acpi_has_method(handle, "_DSM")) {
> - pr_info("No DSM method\n");

And why is printing the message not useful?

> - return -ENODEV;
> - }
> -
> if (!acpi_check_dsm(handle, &adxl_guid, ADXL_REVISION,
> ADXL_IDX_GET_ADDR_PARAMS |
> ADXL_IDX_FORWARD_TRANSLATE)) {
> --
> 2.20.1
>

\
 
 \ /
  Last update: 2019-07-22 10:32    [W:0.075 / U:4.924 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site