Messages in this thread | | | Subject | Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable | From | Stephen Boyd <> | Date | Mon, 22 Jul 2019 14:35:18 -0700 |
| |
Quoting Nathan Huckleberry (2019-06-27 15:22:20) > Clang produces the following warning > > drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable > 'mux_pll_src_3plls_p' [-Wunused-const-variable] > PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; > > Looks like this variable was never used. Deleting it to remove the > warning. > > Cc: clang-built-linux@googlegroups.com > Link: https://github.com/ClangBuiltLinux/linux/issues/524 > Signed-off-by: Nathan Huckleberry <nhuck@google.com> > --- > drivers/clk/rockchip/clk-rv1108.c | 1 - > 1 file changed, 1 deletion(-)
Heiko, can you pick this up? Looks like v5.4 material.
> > diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c > index 96cc6af5632c..5947d3192866 100644 > --- a/drivers/clk/rockchip/clk-rv1108.c > +++ b/drivers/clk/rockchip/clk-rv1108.c > @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" }; > PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" }; > PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" }; > PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" }; > -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; > PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" }; > PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" }; > PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" };
| |