lkml.org 
[lkml]   [2019]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 3/9] x86/mm/tlb: Open-code on_each_cpu_cond_mask() for tlb_is_not_lazy()
Date
> On Jul 22, 2019, at 12:47 PM, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
>
> On 19/07/2019 02.58, Nadav Amit wrote:
>
>> /*
>> @@ -865,7 +893,7 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch)
>> if (cpumask_test_cpu(cpu, &batch->cpumask)) {
>> lockdep_assert_irqs_enabled();
>> local_irq_disable();
>> - flush_tlb_func_local(&full_flush_tlb_info);
>> + flush_tlb_func_local((void *)&full_flush_tlb_info);
>> local_irq_enable();
>> }
>
> I think the confusion could be cleared up if you moved this hunk to
> patch 2 where it belongs - i.e. where you change the prototype of
> flush_tlb_func_local() and hence introduce the warning.

Yes, there is a small mess here - the constification should actually go
to a different patch… I’ll fix it.
\
 
 \ /
  Last update: 2019-07-22 21:52    [W:0.095 / U:42.724 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site