[lkml]   [2019]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] drm/amdkfd: Fix missing break in switch statement

On 7/22/19 2:10 PM, Alex Deucher wrote:
> On Sun, Jul 21, 2019 at 6:12 PM Gustavo A. R. Silva
> <> wrote:
>> Add missing break statement in order to prevent the code from falling
>> through to case CHIP_NAVI10.
>> This bug was found thanks to the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>> Fixes: 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)")
>> Cc:
>> Signed-off-by: Gustavo A. R. Silva <>
> Applied. Thanks!

By the way, Alex, I'm planning to add these fixes to my tree. I want
to send a pull-request to Linus for v5.3-rc2 this afternoon. We want
to have the -Wimplicit-fallthrough option globally enabled in v5.3,
and these are some of the last fall-through warnings remaining in
the kernel.

Can I have your Ack or Signed-off-by for all these drm patches?


 \ /
  Last update: 2019-07-22 21:44    [W:0.066 / U:15.848 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site