lkml.org 
[lkml]   [2019]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [Freedreno] [PATCH 3/3] drm/msm/dsi: make sure we have panel or bridge earlier
    On Tue, Jul 2, 2019 at 2:30 PM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote:
    >
    > On Sun, Jun 30, 2019 at 7:16 AM Rob Clark <robdclark@gmail.com> wrote:
    > > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
    > > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
    > > @@ -1824,6 +1824,20 @@ int msm_dsi_host_init(struct msm_dsi *msm_dsi)
    > > goto fail;
    > > }
    > >
    > > + /*
    > > + * Make sure we have panel or bridge early, before we start
    > > + * touching the hw. If bootloader enabled the display, we
    > > + * want to be sure to keep it running until the bridge/panel
    > > + * is probed and we are all ready to go. Otherwise we'll
    > > + * kill the display and then -EPROBE_DEFER
    > > + */
    > > + if (IS_ERR(of_drm_find_panel(msm_host->device_node)) &&
    > > + !of_drm_find_bridge(msm_host->device_node)) {
    > > + pr_err("%s: no panel or bridge yet\n", __func__);
    >
    > pr_err() doesn't seem right for a probe defer condition. pr_dbg?
    >
    > > + return -EPROBE_DEFER;
    > > + }
    > > +
    > > +
    >
    > Tested-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
    > Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>

    Actually, I'm sorry, I'm now NACKing this.

    Turns out this prevents the panel/bridge from ever probing if its a
    child node of the dsi device, since mipi_dsi_host_register() is never
    called.

    This probably works for you on the c630 because the bridge hangs off
    the i2c bus.

    \
     
     \ /
      Last update: 2019-07-03 02:35    [W:4.094 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site