Messages in this thread | | | Date | Tue, 2 Jul 2019 16:25:33 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH] nvme: fix multipath crash when ANA deactivated |
| |
On Tue, Jul 02, 2019 at 11:52:35AM +0200, Marta Rybczynska wrote: > > They idea was to use a 'ana_log_buf == NULL' as an indicator that ANA is > > disabled, so there is no need to have an additional flag. > > OK, still keeping the split of the helper functions?
I think we can simplify switch nvme_ctrl_use_ana to only check for ->ana_log_buf, and just opencode the actual capabilities check in the setup path.
| |