Messages in this thread | | | From | Arnaldo Carvalho de Melo <> | Date | Tue, 2 Jul 2019 11:02:55 -0300 | Subject | Re: [PATCH 23/43] tools lib: Adopt skip_spaces() from the kernel sources |
| |
Em Tue, Jul 02, 2019 at 03:54:32PM +0200, Jiri Olsa escreveu: > On Tue, Jul 02, 2019 at 10:48:15AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jul 02, 2019 at 10:46:03AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Tue, Jul 02, 2019 at 02:12:40PM +0200, Jiri Olsa escreveu: > > > > this breaks objtool build, because it adds _ctype dependency via isspace call > > > > patch below fixes it for me
> > > Thanks for spotting this, I'll have it in my next pull request.
> > I'm adding a Signed-off-by: you, ok?
> sure, I did not post full patch, because I thought you might thought > of some other solution
I think this is it for now, at some point we need to make a tools/lib/liblinux.{a,so} to group what we're getting from the linux lib/ directory to adapt and use in tools/ living code and then, as a a starter, tools/objtool/ and tools/perf/ should link with it.
- Arnaldo
| |