lkml.org 
[lkml]   [2019]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC V3 12/18] arm64: assembler: Add macro to annotate asm function having non standard stack-frame.
From
Date
Hi,

On 7/1/19 3:40 PM, Catalin Marinas wrote:
> On Mon, Jun 24, 2019 at 10:55:42AM +0100, Raphael Gault wrote:
>> --- a/arch/arm64/include/asm/assembler.h
>> +++ b/arch/arm64/include/asm/assembler.h
>> @@ -752,4 +752,17 @@ USER(\label, ic ivau, \tmp2) // invalidate I line PoU
>> .Lyield_out_\@ :
>> .endm
>>
>> + /*
>> + * This macro is the arm64 assembler equivalent of the
>> + * macro STACK_FRAME_NON_STANDARD define at
>> + * ~/include/linux/frame.h
>> + */
>> + .macro asm_stack_frame_non_standard func
>> +#ifdef CONFIG_STACK_VALIDATION
>> + .pushsection ".discard.func_stack_frame_non_standard"
>> + .8byte \func
>
> Nitpicks:
>
> Does .quad vs .8byte make any difference?
>

No it doesn't, I'll use .quad then.

> Could we place this in include/linux/frame.h directly with a generic
> name (and some __ASSEMBLY__ guards)? It doesn't look to be arm specific.
>

It might be more consistent indeed, I'll do that.

Thanks,

--
Raphael Gault

\
 
 \ /
  Last update: 2019-07-02 11:50    [W:0.069 / U:2.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site