lkml.org 
[lkml]   [2019]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller
From
Date
On Thu, 2019-07-18 at 14:41 -0700, Matthias Kaehlcke wrote:

> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 045b1b13fd0e..e49402ebd56f 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -35,6 +35,7 @@
>
> #include <media/cec-notifier.h>
>
> +#define DDC_I2C_ADDR 0x37

This confused the heck out of me to read, DDC by definition happens
over I2C and this one address is just for a specific subset of DDC.
Perhaps this would be clearer if it was named DDC_CI_ADDR.

- ajax

\
 
 \ /
  Last update: 2019-07-19 18:24    [W:0.051 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site