lkml.org 
[lkml]   [2019]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option
From
Date
On 7/18/19 9:34 PM, Ira Weiny wrote:
> On Thu, Jul 18, 2019 at 06:32:53PM -0700, john.hubbard@gmail.com wrote:
>> From: John Hubbard <jhubbard@nvidia.com>
...
>> + Select HMM_MIRROR if you have hardware that meets the above
>> + description. An early, partial list of such hardware is:
>> + an NVIDIA GPU >= Pascal, Mellanox IB >= mlx5, or an AMD GPU.
>
> I don't think we want to put device information here. If we want that
> information in Kconfig best to put it in the devices themselves. Otherwise
> this list will get stale.
>
> Other than that, looks good.
>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>

Hi Ira, thanks for the review, I'll remove that last sentence. I'll post a v2
with your reviewed by tag, in a new email thread. But first I'll wait to see
if there are other replies.

thanks,
--
John Hubbard
NVIDIA

\
 
 \ /
  Last update: 2019-07-19 07:16    [W:0.088 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site