Messages in this thread | | | Subject | Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option | From | John Hubbard <> | Date | Thu, 18 Jul 2019 22:15:46 -0700 |
| |
On 7/18/19 9:34 PM, Ira Weiny wrote: > On Thu, Jul 18, 2019 at 06:32:53PM -0700, john.hubbard@gmail.com wrote: >> From: John Hubbard <jhubbard@nvidia.com> ... >> + Select HMM_MIRROR if you have hardware that meets the above >> + description. An early, partial list of such hardware is: >> + an NVIDIA GPU >= Pascal, Mellanox IB >= mlx5, or an AMD GPU. > > I don't think we want to put device information here. If we want that > information in Kconfig best to put it in the devices themselves. Otherwise > this list will get stale. > > Other than that, looks good. > > Reviewed-by: Ira Weiny <ira.weiny@intel.com> >
Hi Ira, thanks for the review, I'll remove that last sentence. I'll post a v2 with your reviewed by tag, in a new email thread. But first I'll wait to see if there are other replies.
thanks, -- John Hubbard NVIDIA
| |