lkml.org 
[lkml]   [2019]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.2 092/171] powerpc/cacheflush: fix variable set but not used
    Date
    From: Qian Cai <cai@lca.pw>

    [ Upstream commit 04db3ede40ae4fc23a5c4237254c4a53bbe4c1f2 ]

    The powerpc's flush_cache_vmap() is defined as a macro and never use
    both of its arguments, so it will generate a compilation warning,

    lib/ioremap.c: In function 'ioremap_page_range':
    lib/ioremap.c:203:16: warning: variable 'start' set but not used
    [-Wunused-but-set-variable]

    Fix it by making it an inline function.

    Signed-off-by: Qian Cai <cai@lca.pw>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/include/asm/cacheflush.h | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/arch/powerpc/include/asm/cacheflush.h b/arch/powerpc/include/asm/cacheflush.h
    index 74d60cfe8ce5..fd318f7c3eed 100644
    --- a/arch/powerpc/include/asm/cacheflush.h
    +++ b/arch/powerpc/include/asm/cacheflush.h
    @@ -29,9 +29,12 @@
    * not expect this type of fault. flush_cache_vmap is not exactly the right
    * place to put this, but it seems to work well enough.
    */
    -#define flush_cache_vmap(start, end) do { asm volatile("ptesync" ::: "memory"); } while (0)
    +static inline void flush_cache_vmap(unsigned long start, unsigned long end)
    +{
    + asm volatile("ptesync" ::: "memory");
    +}
    #else
    -#define flush_cache_vmap(start, end) do { } while (0)
    +static inline void flush_cache_vmap(unsigned long start, unsigned long end) { }
    #endif

    #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-07-19 06:37    [W:4.302 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site