lkml.org 
[lkml]   [2019]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] lpss8250_dma_setup: there is memory leak when second allocation fails
On Sat, Jul 20, 2019 at 1:23 AM Navid Emamdoost
<navid.emamdoost@gmail.com> wrote:
>
> in lpss8250_dma_setup, we need to release the first dma slave object
> allocated in case of the second allocation failure.
>

This will bring a double free instead of fixing anything.

NAK.

> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
> drivers/tty/serial/8250/8250_lpss.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c
> index d07e431110d9..6e1f86db88b2 100644
> --- a/drivers/tty/serial/8250/8250_lpss.c
> +++ b/drivers/tty/serial/8250/8250_lpss.c
> @@ -259,8 +259,10 @@ static int lpss8250_dma_setup(struct lpss8250 *lpss, struct uart_8250_port *port
> return -ENOMEM;
>
> tx_param = devm_kzalloc(dev, sizeof(*tx_param), GFP_KERNEL);
> - if (!tx_param)
> + if (!tx_param) {
> + kfree(rx_param);
> return -ENOMEM;
> + }
>
> *rx_param = lpss->dma_param;
> dma->rxconf.src_maxburst = lpss->dma_maxburst;
> --
> 2.17.1
>


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-07-20 00:36    [W:0.078 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site