Messages in this thread | | | Date | Thu, 18 Jul 2019 15:08:35 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n |
| |
On Thu, Jul 18, 2019 at 03:03:15PM +0200, Arnd Bergmann wrote: > The inclusion comes from the recently added header check in commit > c93a0368aaa2 ("kbuild: do not create wrappers for header-test-y"). > > This just tries to include every header by itself to see if there are build > failures from missing indirect includes. We probably don't want to > add an exception for iomap.h there.
I very much disagree with that check. We don't need to make every header compilable with a setup where it should not be included.
That being said if you feel this is worth fixing I'd rather define SECTOR_SIZE/SECTOR_SHIFT unconditionally.
| |