lkml.org 
[lkml]   [2019]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4, 25/33] drm/mediatek: add clock property check before get it
    From
    Date
    Hi, Yongqiang:

    On Tue, 2019-07-09 at 06:34 +0800, yongqiang.niu@mediatek.com wrote:
    > From: Yongqiang Niu <yongqiang.niu@mediatek.com>
    >
    > This patch add clock property check before get it
    >
    > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
    > ---
    > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++----
    > 1 file changed, 6 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
    > index c57e7ab..a9d3e27 100644
    > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
    > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
    > @@ -668,10 +668,12 @@ static int mtk_ddp_probe(struct platform_device *pdev)
    > for (i = 0; i < 10; i++)
    > ddp->mutex[i].id = i;
    >
    > - ddp->clk = devm_clk_get(dev, NULL);
    > - if (IS_ERR(ddp->clk)) {
    > - dev_err(dev, "Failed to get clock\n");
    > - return PTR_ERR(ddp->clk);
    > + if (of_find_property(dev->of_node, "clocks", &i)) {
    > + ddp->clk = devm_clk_get(dev, NULL);
    > + if (IS_ERR(ddp->clk)) {
    > + dev_err(dev, "Failed to get clock\n");
    > + return PTR_ERR(ddp->clk);
    > + }

    Only "mediatek,mt8133-disp-mutex" has no clock property. For other SoC,
    clock property is required. So I think this exception is just for
    mt8183.

    Regards,
    CK

    > }
    >
    > regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);


    \
     
     \ /
      Last update: 2019-07-17 09:03    [W:3.445 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site