lkml.org 
[lkml]   [2019]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.1 13/54] arm64: dts: ls1028a: Fix CPU idle fail.
    Date
    [ Upstream commit 53f2ac9d3aa881ed419054076042898b77c27ee4 ]

    PSCI spec define 1st parameter's bit 16 of function CPU_SUSPEND to
    indicate CPU State Type: 0 for standby, 1 for power down. In this
    case, we want to select standby for CPU idle feature. But current
    setting wrongly select power down and cause CPU SUSPEND fail every
    time. Need this fix.

    Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
    Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
    Signed-off-by: Shawn Guo <shawnguo@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 +++++++++---------
    1 file changed, 9 insertions(+), 9 deletions(-)

    diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
    index 2896bbcfa3bb..228872549f01 100644
    --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
    +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
    @@ -28,7 +28,7 @@
    enable-method = "psci";
    clocks = <&clockgen 1 0>;
    next-level-cache = <&l2>;
    - cpu-idle-states = <&CPU_PH20>;
    + cpu-idle-states = <&CPU_PW20>;
    };

    cpu1: cpu@1 {
    @@ -38,7 +38,7 @@
    enable-method = "psci";
    clocks = <&clockgen 1 0>;
    next-level-cache = <&l2>;
    - cpu-idle-states = <&CPU_PH20>;
    + cpu-idle-states = <&CPU_PW20>;
    };

    l2: l2-cache {
    @@ -53,13 +53,13 @@
    */
    entry-method = "arm,psci";

    - CPU_PH20: cpu-ph20 {
    - compatible = "arm,idle-state";
    - idle-state-name = "PH20";
    - arm,psci-suspend-param = <0x00010000>;
    - entry-latency-us = <1000>;
    - exit-latency-us = <1000>;
    - min-residency-us = <3000>;
    + CPU_PW20: cpu-pw20 {
    + compatible = "arm,idle-state";
    + idle-state-name = "PW20";
    + arm,psci-suspend-param = <0x0>;
    + entry-latency-us = <2000>;
    + exit-latency-us = <2000>;
    + min-residency-us = <6000>;
    };
    };

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-07-18 05:05    [W:4.059 / U:0.680 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site