lkml.org 
[lkml]   [2019]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock
From
Date

>> * mcs_node
>> * +--------+ +----+ +----+
>> * | next | ---> |next| -> ... |next| -> NULL [Main queue]
>> * | locked | -+ +----+ +----+
>> * +--------+ |
>> * | +---------+ +----+
>> * +-> |mcs::next| -> ... |next| -> NULL [Secondary queue]
>> * |cna::tail| -+ +----+
>> * +---------+ | ^
>> * +--------+
>> *
>> * N.B. locked = 1 if secondary queue is absent.
>> */


I would change mcs_node to cna_node, next to mcs::next and locked to mcs::locked
in the very first node. Other than that, this is great. Thanks, Peter and Longman!

I should probably stick this graphic in the comment at the top of the file,
instead of a comment to find_successor() (or whatever this function ends up
being called).

— Alex


\
 
 \ /
  Last update: 2019-07-17 16:44    [W:0.059 / U:1.568 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site