lkml.org 
[lkml]   [2019]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4, 12/33] drm/mediatek: split DISP_REG_CONFIG_DSI_SEL setting into another use case
    From
    Date
    Hi, Yongqiang:

    On Tue, 2019-07-09 at 06:33 +0800, yongqiang.niu@mediatek.com wrote:
    > From: Yongqiang Niu <yongqiang.niu@mediatek.com>
    >
    > Here is two modifition in this patch:
    > 1.bls->dpi0 and rdma1->dsi are differen usecase,
    > Split DISP_REG_CONFIG_DSI_SEL setting into anther usecase
    > 2.remove DISP_REG_CONFIG_DPI_SEL setting, DPI_SEL_IN_BLS is 0 and
    > this is same with hardware defautl setting,
    >

    You move 2 register setting out of the path from BLS to DPI0, does this
    path still work? Please make sure that all modification could work on
    all supported SoC.

    Regards,
    CK

    > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
    > ---
    > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
    > index d015c1a..47b3e35 100644
    > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
    > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
    > @@ -400,10 +400,9 @@ static void mtk_ddp_sout_sel(void __iomem *config_regs,
    > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) {
    > writel_relaxed(BLS_TO_DPI_RDMA1_TO_DSI,
    > config_regs + DISP_REG_CONFIG_OUT_SEL);
    > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) {
    > writel_relaxed(DSI_SEL_IN_RDMA,
    > config_regs + DISP_REG_CONFIG_DSI_SEL);
    > - writel_relaxed(DPI_SEL_IN_BLS,
    > - config_regs + DISP_REG_CONFIG_DPI_SEL);
    > }
    > }
    >


    \
     
     \ /
      Last update: 2019-07-17 07:36    [W:4.155 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site